Skip to content

Conversation

@Karsten1987
Copy link
Contributor

supersedes #64

@olivier-stasse I hope you don't mind, but I kind of took over your PR and fixed up a bunch of things to make Gazebo actually work. With that being said, please disregard olivier-stasse#1
The delay we're seeing is due to the URDF being somewhat incomplete in which the description does not deliver the hokuyo.dae mesh file. Gazebo will thus try to find it desperately and eventually time out.
I added the mesh explicitly and set up a hook for Gazebo for load it on its model path.

@codecov-commenter
Copy link

codecov-commenter commented Apr 28, 2021

Codecov Report

Merging #85 (3249994) into master (4cb4898) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #85   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files           3       3           
  Lines         283     283           
======================================
  Misses        283     283           
Flag Coverage Δ
unittests 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../ros2_control_demo_hardware/src/diffbot_system.cpp
...l_demo_hardware/src/rrbot_system_position_only.cpp
...demo_hardware/src/rrbot_system_multi_interface.cpp
...l_demo_hardware/src/rrbot_system_position_only.cpp 0.00% <0.00%> (ø)
...demo_hardware/src/rrbot_system_multi_interface.cpp 0.00% <0.00%> (ø)
.../ros2_control_demo_hardware/src/diffbot_system.cpp 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cb4898...3249994. Read the comment docs.

Signed-off-by: Karsten Knese <[email protected]>
Signed-off-by: Karsten Knese <[email protected]>
@Karsten1987
Copy link
Contributor Author

I also corrected the URDF. The base link was set to 0.2m in height, and I believe it should rather be 2m.
When trying to load the joint state controller, one gets an exception because of name conflict. That has to do with the current duplication/renaming from joint_state_controller to joint_state_broadcaster. I've also addressed this.

@olivier-stasse
Copy link
Collaborator

olivier-stasse commented Apr 28, 2021

@olivier-stasse I hope you don't mind, but I kind of took over your PR and fixed up a bunch of things to make Gazebo actually work.

Dear @Karsten1987 not at all, thanks for fixing this and all the rest.
I hope you found #64 useful, let me know when you want me to close it.

@Karsten1987
Copy link
Contributor Author

I guess you could close your PR already, all your initial commits are still here on this PR. Would be great to have this merged at some point to have some Gazebo support upstream.

@Karsten1987
Copy link
Contributor Author

@destogl do you mind having a look at this?

@bmagyar
Copy link
Member

bmagyar commented May 1, 2021

@Karsten1987 please mind what you have on a branch, this happened to have the contents of #89 as well which normally wouldn't be an issue but given that changes weren't cherry-picked to Olivier's branch but merged into, I couldn't just remove them by rebasing, had to opt for adding another magic blob merge commit to fix things.

@bmagyar
Copy link
Member

bmagyar commented May 2, 2021

Managed to fix my gazebo setup (I think, although it's now shaky, see gif) and tested this.

Peek 2021-05-02 07-53

Merging...

@bmagyar bmagyar merged commit ecb96f5 into master May 2, 2021
@destogl destogl deleted the kk/rrbot_gazebo branch May 3, 2021 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants